Discogs Tagger 5.71 (Updated: 2019-09-23)

Download and get help for different MediaMonkey Addons.

Moderators: Peke, Gurus

Eyal
Posts: 3110
Joined: Sun Jun 26, 2005 9:27 am
Location: Québec

Re: Discogs Tagger 5.41 (Updated: 2016-10-15)

Post by Eyal » Sun Oct 16, 2016 5:19 pm

@ DJSamhein,
It's not Discogs problem, neither a script problem, it's the Discogs' submitter that entered trailing spaces in these titles (track 2 and 4 to 10) in release 9166475.
This often occurs when the user copy/paste titles from another website.
These leading/trailing spaces should be edited and removed in discog's database. Personally I have fixed several entries like these in the past, and warned the user to be careful about it. Discogs is a respectable database and IMO this kind of errors are not acceptable.
Skins for MediaMonkey: Cafe, Carbon, Helium, Spotify, Zekton. [ Wiki Zone ].

crap_inhuman
Posts: 688
Joined: Sat Jan 26, 2013 6:00 am
Location: Friedberg / Hessen / Germany
Contact:

Re: Discogs Tagger 5.41 (Updated: 2016-10-15)

Post by crap_inhuman » Tue Oct 18, 2016 1:11 pm

Eyal wrote:@ DJSamhein,
It's not Discogs problem, neither a script problem, it's the Discogs' submitter that entered trailing spaces in these titles (track 2 and 4 to 10) in release 9166475.
This often occurs when the user copy/paste titles from another website.
These leading/trailing spaces should be edited and removed in discog's database. Personally I have fixed several entries like these in the past, and warned the user to be careful about it. Discogs is a respectable database and IMO this kind of errors are not acceptable.
Full Ack ! I fixed several entries in the discogs database, too.

But what is the best way now ?

The script should delete leading/trailing spaces. But the discogs database should be fixed, too.

I could write the involved releases in a database and publish it elsewhere?

Any suggestions are welcome
Metal up your ass !
-----------------------------------------------
I added my first 2 videos on youtube. The language is german.

Discogs Autorisierung: https://www.youtube.com/watch?v=oryxKKtnEnc
Discogs Tagger Bedienung: https://www.youtube.com/watch?v=85Wk-5rd-W0

DJSamhein
Posts: 89
Joined: Tue Oct 20, 2009 5:43 am

Re: Discogs Tagger 5.41 (Updated: 2016-10-15)

Post by DJSamhein » Thu Oct 20, 2016 4:21 am

Do you have any control in any phase between the discogs submitter and the tag writing phases? Or does the submitter write the tags himself?
In the first case, simply trim the results from the submitter.
In the second case, which is what I think actually happens, just loop the tracks in the end, after the submitter is done with them, trimming as required.

crap_inhuman
Posts: 688
Joined: Sat Jan 26, 2013 6:00 am
Location: Friedberg / Hessen / Germany
Contact:

Re: Discogs Tagger 5.41 (Updated: 2016-10-15)

Post by crap_inhuman » Thu Oct 20, 2016 1:08 pm

I don't understand your post completely. Please correct me, if i thought the wrong way.

The discogs submitter create the release at discogs and store the track names with leading/trailing spaces.
Viewing the release at the Discogs website doesn't show the leading/trailing spaces. You can only see them, if you "Edit Release".

The Discogs Tagger Script get the track names with leading/trailing spaces through the api interface.

In Version 5.42, the script check for leading/trailing spaces. If it found them, the names will be trimmed and the release-number will be stored in a mysql db on my webspace. I fix them at discogs from time to time. I hope there are not too much releases with l/t spaces.. :wink:

EDIT: After 12 hours of releasing the new version there are 4 releases with l/t spaces in the db... Do i really hope that there are not too much releases ? :-?

4276147
4424297
8319458
9166475

EDIT EDIT:

Just fixed the releases.
If you wanna see the release-list with l/t spaces: http://germanc64.de/mm/oauth/show_release.php
Last edited by crap_inhuman on Fri Oct 21, 2016 12:57 pm, edited 3 times in total.
Metal up your ass !
-----------------------------------------------
I added my first 2 videos on youtube. The language is german.

Discogs Autorisierung: https://www.youtube.com/watch?v=oryxKKtnEnc
Discogs Tagger Bedienung: https://www.youtube.com/watch?v=85Wk-5rd-W0

crap_inhuman
Posts: 688
Joined: Sat Jan 26, 2013 6:00 am
Location: Friedberg / Hessen / Germany
Contact:

Re: Discogs Tagger 5.42 (Updated: 2016-10-20)

Post by crap_inhuman » Thu Oct 20, 2016 2:14 pm

I just release the version V5.42

You can read the changes in the previous post.
Metal up your ass !
-----------------------------------------------
I added my first 2 videos on youtube. The language is german.

Discogs Autorisierung: https://www.youtube.com/watch?v=oryxKKtnEnc
Discogs Tagger Bedienung: https://www.youtube.com/watch?v=85Wk-5rd-W0

DJSamhein
Posts: 89
Joined: Tue Oct 20, 2009 5:43 am

Re: Discogs Tagger 5.42 (Updated: 2016-10-20)

Post by DJSamhein » Wed Oct 26, 2016 3:31 am

What I had meant was if you had any control over the tracks after the API was done tagging. I thought the submitter was what you used to tag, it was just some confusion on the names :)

If you still have control after the API is done tagging the files, it would be simpler to simply iterate the files and trimming.

DJSamhein
Posts: 89
Joined: Tue Oct 20, 2009 5:43 am

Re: Discogs Tagger 5.42 (Updated: 2016-10-20)

Post by DJSamhein » Wed Oct 26, 2016 4:45 am

By the way, it isn't quite fixed yet. The release r8826986 still tried to add a space to the album name.

DJSamhein
Posts: 89
Joined: Tue Oct 20, 2009 5:43 am

Re: Discogs Tagger 5.42 (Updated: 2016-10-20)

Post by DJSamhein » Thu Oct 27, 2016 5:13 am

Also, sorry to keep bothering for these small things, but there is one slightly annoying thing that you could maybe fix:
-When there are releases that have, for example, names for different discs, that "track" is unselected, as it should be because it's only the disc name and not a track. However, when you switch to another release that has a normal playlist, the same tracks remain unselected.

This wouldn't be such a big deal if it weren't for the fact that selecting/deselecting any option (track, artist, album, etc) has a slight delay that becomes really annoying for lots of tracks. And if we try to select/deselect many at once we are often presented with a script error MsgBox.

The best solution would be to fix that delay, but it's been like that for a while, so I assume it wouldn't be easy. Failing that, maybe you could treat release changes as a new load of sorts, so it resets the selected tracks?

crap_inhuman
Posts: 688
Joined: Sat Jan 26, 2013 6:00 am
Location: Friedberg / Hessen / Germany
Contact:

Re: Discogs Tagger 5.42 (Updated: 2016-10-20)

Post by crap_inhuman » Thu Oct 27, 2016 8:24 pm

DJSamhein wrote:What I had meant was if you had any control over the tracks after the API was done tagging. I thought the submitter was what you used to tag, it was just some confusion on the names :)
Got it. :D
DJSamhein wrote:By the way, it isn't quite fixed yet. The release r8826986 still tried to add a space to the album name.
I only checked and fixed it to track-names. In version 5.43 i will add it to album-names, too. :wink:
DJSamhein wrote:Also, sorry to keep bothering for these small things, but there is one slightly annoying thing that you could maybe fix:
-When there are releases that have, for example, names for different discs, that "track" is unselected, as it should be because it's only the disc name and not a track. However, when you switch to another release that has a normal playlist, the same tracks remain unselected.

This wouldn't be such a big deal if it weren't for the fact that selecting/deselecting any option (track, artist, album, etc) has a slight delay that becomes really annoying for lots of tracks. And if we try to select/deselect many at once we are often presented with a script error MsgBox.

The best solution would be to fix that delay, but it's been like that for a while, so I assume it wouldn't be easy. Failing that, maybe you could treat release changes as a new load of sorts, so it resets the selected tracks?
I have this for a long time on my To-Do list. It should be easy to fix the unselected tracks after switching to another release.
Removing the delay between select/deselect is on my list, too. But fixing this is a little bit tricky. Maybe in a future version. :wink:

And hey, don't stop bothering me. I need this to continue the work on this project. :wink:
Metal up your ass !
-----------------------------------------------
I added my first 2 videos on youtube. The language is german.

Discogs Autorisierung: https://www.youtube.com/watch?v=oryxKKtnEnc
Discogs Tagger Bedienung: https://www.youtube.com/watch?v=85Wk-5rd-W0

DJSamhein
Posts: 89
Joined: Tue Oct 20, 2009 5:43 am

Re: Discogs Tagger 5.42 (Updated: 2016-10-20)

Post by DJSamhein » Fri Oct 28, 2016 3:30 am

Well, I have to say you're doing a great job. This is an excellent tool and the fact that you still keep listening to the users and making changes is something many devs don't do. So Kudos to you, sir :)

steviegt
Posts: 311
Joined: Tue Mar 17, 2009 8:39 am

Re: Discogs Tagger 5.42 (Updated: 2016-10-20)

Post by steviegt » Mon Oct 31, 2016 2:53 pm

Fresh install of Windows & MM. Downloaded Discogs from addons. Is a zip file and not an mmip. I unzipped and placed the install.vbs, DiscogsOptions.vbs and install.ini in c:\Program Files (x86)\MediaMonkey\Scripts\Auto\. I placed the DiscogsAutoTagWeb.vbs in c:\Program Files (x86)\MediaMonkey\Scripts\. I read that in the install.ini for placement. I authorized and the script works fine. However, the script does not show up in the Extentions windows in MM. Is download and install supposed to work this way? Where is the .mmip file?
MMW Gold Lifetime v4.1.21.11875
MM Pro Android v1.3.2.0824
Windows Home 10.0.17134.228 64-bit Build 1803
MS Edge


Next to MediaMonkey, the best program available: Total Commander http://www.ghisler.com/

"Being mean to someone takes more effort than being nice to them"

crap_inhuman
Posts: 688
Joined: Sat Jan 26, 2013 6:00 am
Location: Friedberg / Hessen / Germany
Contact:

Re: Discogs Tagger 5.42 (Updated: 2016-10-20)

Post by crap_inhuman » Mon Oct 31, 2016 2:57 pm

DJSamhein wrote:Well, I have to say you're doing a great job. This is an excellent tool and the fact that you still keep listening to the users and making changes is something many devs don't do. So Kudos to you, sir :)
Thank you for the Kudos DJSamhein :)

Guest wrote:no Thank You for this plugin!
i'm just tagging my CD collection of several thousand CD, and this plugin is a complete life safer :)

Just tested the new version with a few CDs and it's working great with Various Artists albums so far

thank you
Getting suchlike posts make me proud and happy. Thank you! :)
Metal up your ass !
-----------------------------------------------
I added my first 2 videos on youtube. The language is german.

Discogs Autorisierung: https://www.youtube.com/watch?v=oryxKKtnEnc
Discogs Tagger Bedienung: https://www.youtube.com/watch?v=85Wk-5rd-W0

crap_inhuman
Posts: 688
Joined: Sat Jan 26, 2013 6:00 am
Location: Friedberg / Hessen / Germany
Contact:

Re: Discogs Tagger 5.42 (Updated: 2016-10-20)

Post by crap_inhuman » Mon Oct 31, 2016 3:00 pm

steviegt wrote:Fresh install of Windows & MM. Downloaded Discogs from addons. Is a zip file and not an mmip. I unzipped and placed the install.vbs, DiscogsOptions.vbs and install.ini in c:\Program Files (x86)\MediaMonkey\Scripts\Auto\. I placed the DiscogsAutoTagWeb.vbs in c:\Program Files (x86)\MediaMonkey\Scripts\. I read that in the install.ini for placement. I authorized and the script works fine. However, the script does not show up in the Extentions windows in MM. Is download and install supposed to work this way? Where is the .mmip file?
Hi steviegt,

i just looked on the server and it is a mmip file. I think Windows renamed it to .zip. Please rename the downloaded file to .mmip and open it again. It should works!
Metal up your ass !
-----------------------------------------------
I added my first 2 videos on youtube. The language is german.

Discogs Autorisierung: https://www.youtube.com/watch?v=oryxKKtnEnc
Discogs Tagger Bedienung: https://www.youtube.com/watch?v=85Wk-5rd-W0

steviegt
Posts: 311
Joined: Tue Mar 17, 2009 8:39 am

Re: Discogs Tagger 5.42 (Updated: 2016-10-20)

Post by steviegt » Mon Oct 31, 2016 3:10 pm

Yes sir that was it. I renamed .zip to .mmip and it ran properly. Thank you. I just started using Edge. I'll go thru settings and see if there is an option to change that behavior. :D
MMW Gold Lifetime v4.1.21.11875
MM Pro Android v1.3.2.0824
Windows Home 10.0.17134.228 64-bit Build 1803
MS Edge


Next to MediaMonkey, the best program available: Total Commander http://www.ghisler.com/

"Being mean to someone takes more effort than being nice to them"

crap_inhuman
Posts: 688
Joined: Sat Jan 26, 2013 6:00 am
Location: Friedberg / Hessen / Germany
Contact:

Re: Discogs Tagger 5.42 (Updated: 2016-10-20)

Post by crap_inhuman » Mon Oct 31, 2016 3:17 pm

steviegt wrote:Yes sir that was it. I renamed .zip to .mmip and it ran properly. Thank you. I just started using Edge. I'll go thru settings and see if there is an option to change that behavior. :D
Great ! I hope you can change this. :)

Bill Gates would say: It's not a bug, it's a feature :roll:
Metal up your ass !
-----------------------------------------------
I added my first 2 videos on youtube. The language is german.

Discogs Autorisierung: https://www.youtube.com/watch?v=oryxKKtnEnc
Discogs Tagger Bedienung: https://www.youtube.com/watch?v=85Wk-5rd-W0

Post Reply