Page 2 of 3
Re: Adding a lyric source
Posted: Fri Sep 03, 2021 1:44 pm
by fizzjob
TIV73 wrote: ↑Mon Aug 30, 2021 12:38 pm
Try this.
- Create a new folder called lyricSourceDummy in
[MM5 Installation directory]/Scripts/
- Clone or download the lyrics search dummy addon from
this repo
- Put all the files in the newly created folder. The path to your info.json should be
[MM5 Installation directory]/Scripts/lyricSourceDummy/info.json
- Restart mediamonkey
- Open the properties of a track
- Navigate to the Lyrics tab and press the magnifier icon in the top right corner
If everything is set up correctly, you should get a js alert telling you that the dummy addon has been loaded. If you inspect the lyricsSearch.js file, you should see all code that was defined in the lyricsSearch_add.js file of the addon.
That got it! Using that as a template I have created a lyricSourceGenius folder and it works. Now it's just packaging the addon. Thanks for the help!
edit: ...and it's submitted! First time ever doing anything with node.js and npm. I'm learning all around today!
Re: Adding a lyric source
Posted: Fri Sep 03, 2021 2:03 pm
by TIV73
Congratulations on your first addon!
Re: Adding a lyric source
Posted: Fri Sep 03, 2021 3:04 pm
by drakinite
fizzjob wrote: ↑Fri Sep 03, 2021 1:44 pm
edit: ...and it's submitted! First time ever doing anything with node.js and npm. I'm learning all around today!
Congrats; great work! However, before I can approve it: You forgot to fix that one error I pointed out earlier. The addon breaks when lyrics cannot be found, because you need to
call requestNext() on line 16.
On the Submit Addon page, you should be able to edit the submitted version by clicking on Version Information on the right, then selecting a new file like so:
http://files.drakinite.net/2021-09-03_15-58-51.mp4
Re: Adding a lyric source
Posted: Fri Sep 03, 2021 3:37 pm
by fizzjob
TIV73 wrote: ↑Fri Sep 03, 2021 2:03 pm
Congratulations on your first addon!
Well, not my
first, but my first for MM5.
drakinite wrote: ↑Fri Sep 03, 2021 3:04 pm
Congrats; great work! However, before I can approve it: You forgot to fix that one error I pointed out earlier. The addon breaks when lyrics cannot be found, because you need to
call requestNext() on line 16.
On the Submit Addon page, you should be able to edit the submitted version by clicking on Version Information on the right, then selecting a new file like so:
http://files.drakinite.net/2021-09-03_15-58-51.mp4
Fixed and submitted, thanks for the reminder.
Re: Adding a lyric source
Posted: Fri Sep 03, 2021 4:47 pm
by drakinite
Approved!
Re: Adding a lyric source
Posted: Sat Sep 04, 2021 8:17 am
by jess12345
Been testing this add-on Tonight... Finding alot of lyrics I couldn't get before so thanks mate!! But it seems to not be grabbing all the lyrics, just part of them... But good job for your first add-on bro. I can't do anything like that so just wanted to say good job.
Re: Adding a lyric source
Posted: Sat Sep 04, 2021 3:53 pm
by IanRTaylorUK
Looks like a really useful add-on.
I have previously used Lyricator in MMW4 and so only have a few MP3 left without lyrics.
I tried the add-on but not finding lyrics - probably because there aren't any.
However, one thing I am not certain about. Is this add-on intended to be used on a single selection or cannot it be used to multi-select?
Re: Adding a lyric source
Posted: Sun Sep 05, 2021 2:23 am
by Zonky
IanRTaylorUK wrote: ↑Sat Sep 04, 2021 3:53 pm
However, one thing I am not certain about. Is this add-on intended to be used on a single selection or cannot it be used to multi-select?
I've recently asked this question and was advised that this is not the case and there is no intention to do this since this might violate the websites policies for mass grabbing lyrics which will probably lead to a lockout of MM.
MM4 did not care about this, so I guess it's just a matter of time until MM5 will give us a bulk update of lyrics again. Otherwise the current lyrics feature is not very convenient...
Re: Adding a lyric source
Posted: Sun Sep 05, 2021 3:42 am
by IanRTaylorUK
Thanks Zonky,
So I am better to use Lyricator with MMW4 for block updating with it 11(?) websites than looking up individual files with 7 sources.
Re: Adding a lyric source
Posted: Tue Sep 07, 2021 12:57 pm
by Zonky
drakinite wrote: ↑Fri Sep 03, 2021 4:47 pm
Approved!
Guess I've found a bug when seeking for lyrics for the below mp3 file.
Genius returns in this case:
Code: Select all
[Verse 1]
<a href="/4794116/London-grammar-nightcall/Im-giving-you-a-nightcall-to-tell-you-how-i-feel-im-gonna-drive-you-through-the-night-down-the-hills-im-gonna-tell-you-something-you-dont-want-to-hear-im-gonna-show-you-where-its-dumped-but-have-no-fear" class="ReferentFragment__ClickTarget-oqvzi6-0 evuxZm
MP3 properties:
Code: Select all
Title: "Nightcall (Raaja Bones & Fyfe Dangerfield Remix)"
Artists: "London Grammar"
Album: "Nightcall"
Album Artists: "London Grammar"
Do you need more details for investigation if all?
Re: Adding a lyric source
Posted: Tue Sep 07, 2021 8:08 pm
by Peke
Hi,
Are you using 5.0.2.2500 beta as in that version all HTML tags should be stripped.
Re: Adding a lyric source
Posted: Thu Sep 09, 2021 12:27 pm
by Zonky
Peke wrote: ↑Tue Sep 07, 2021 8:08 pm
Hi,
Are you using 5.0.2.2500 beta as in that version all HTML tags should be stripped.
Yes, I do!
Can I debug this at the time the lyrics get fetched? As mentioned above, I'm running the beta, debug version, so I assume the Chrome console should do the job, right.
Did not try it myself because of lack of some information how to debug inside MM.
Re: Adding a lyric source
Posted: Fri Sep 10, 2021 2:40 pm
by Ludek
Re: Adding a lyric source
Posted: Sat Sep 18, 2021 7:29 am
by Zonky
So, still no success with the above given track and Genius lyrics search
Still getting some html code mixed with the lyrics itselft.
I tried to debug this after noticing I need Chrome installed (running exclusively Firefox) to get the debug running
Nevertheless I added a breakpoint in source helpers\lyricsSearch.js at line ~986
Code: Select all
rGenius.host = 'https://genius.com/%artist%-%title%-lyrics';
After opening the tracks' properties I switched to Lyrics tab and executed the lyrics search. I assumed it stops at the line I previously added a breakpoint - but it didn't.
So any hint available how I could stop at the time lyrics search is running or better when Genius search gets called? FYI it does not stop either when setting up a breakpoint at any line in lyricsSearch.js.
Of course Genius as a source for lyrics lookup is active in settings.
Re: Adding a lyric source
Posted: Wed Sep 29, 2021 6:12 am
by Zonky
So, I still want to debug this and still no solution for the Chrome debugger not stopping at the point of interest...
Anyone has got any hint for me?
