My MM4 db has become upgraded to MM5 somehow? [#16718]

by **Barry4679** » Tue Jul 21, 2020 8:37 am

PetrCBR wrote: ↑Tue Jul 21, 2020 5:17 am Final decision about portable installation is the database will copy to portable folder even when custom location is defined in the imported ini.

good, thanks

by **PetrCBR** » Tue Jul 21, 2020 5:17 am

Final decision about portable installation is the database will copy to portable folder even when custom location is defined in the imported ini.

by **Barry4679** » Tue Jul 21, 2020 2:37 am

PetrCBR wrote: ↑Sat Jul 04, 2020 10:09 am When you choose to import settings from previous version, then yes you will use this settings. When you need to start from scratch, do not import settings.

EDIT: anyhow i've sent your suggestion about portable mode to other guys so we will discuss this internally

What was the outcome of your internal discussion?

It seems clear to me that the default database location in portable mode should always be within the portable sub-directory

This is what your wiki says

Portable Mode:
In the 'Portable' subdirectory of the location to which MediaMonkey was installed. e.g.
<MediaMonkey Portable Install Folder>\Portable\MM.DB
<MediaMonkey Portable Install Folder>\Portable\MediaMonkey.ini

IMO this should apply in all cases, ie. including when allowing import and settings from MM4 installation.

by **PetrCBR** » Sun Jul 05, 2020 11:38 am

With Barry we've finally found the issue and it will be fixed in 2260. Thanks for your assistance, Barry

.

by **Barry4679** » Sat Jul 04, 2020 10:29 am

PetrCBR wrote: ↑Sat Jul 04, 2020 10:09 am When you choose to import settings from previous version, then yes you will use this settings. When you need to start from scratch, do not import settings.

EDIT: anyhow i've sent your suggestion about portable mode to other guys so we will discuss this internally

OK, good ... just to be clear, the question asks do you want to import from your database ... most people would want that because the other way means that we have to thrash our disk drives to read all the tags again, and then we lose play counts, and custom tags, and track ratings .... so you can't rely on this choice as being that they also want ALL their settings also ... it is probably best, and safest, if you never transfer the custom db location setting .... or at least show them what you are about to do on the top dbox shown at the top here, and get them to agree to it ... IMO that is a bare minimum ... and best choice is to put the database in the standard locations always, ie. for both normal and portable installs.

by **PetrCBR** » Sat Jul 04, 2020 10:09 am

When you choose to import settings from previous version, then yes you will use this settings. When you need to start from scratch, do not import settings.

EDIT: anyhow i've sent your suggestion about portable mode to other guys so we will discuss this internally

by **Barry4679** » Sat Jul 04, 2020 9:50 am

PetrCBR wrote: ↑Sat Jul 04, 2020 7:54 am I've added code to always use MM5.DB even when different name is defined in INI file to be sure MM4 database isn't used in case INI file is not updated after data import.

Doesn't this mean that if I person was already on MM5, with a standard db file name in custom db location, and then requested a separate portable install ==> you would import the ini file into the portable folder, and this would mean that both the main install of MM5, and this new portable install, would both be using the one database ... that's a disaster waiting to happen, isn't it? .... ie. someone installs a portable version 0f MM5, does some slash and burn while experimenting with MM5, and it stuffs up their main database.

by **Barry4679** » Sat Jul 04, 2020 9:43 am

PetrCBR wrote: ↑Sat Jul 04, 2020 7:19 am Even in portable mode you can define custom DB location and when you've choosed to import settings from MM4, custom DB location was imported as well.

The question in the dbox specifically asked whether I wanted to import my database from MM4, it didn't mention settings. ... although the dbox heading may have said something about settings, I am not sure.

The point is that there is no way to import db, but not settings, during your MM5 install proc, so you can't rely upon that fact that the user said Yes to import, meaning that people want the db to be created outside the portable installation.

I think that if the user has requested a "portable" installation, you should import data from the user's custom MM4 database, but comment out the custom location in the ini file that you copy into to MM5/portable ... so that the user does get the portable install that they have requested for ... ie. you should not assume that they want the database in a non-portable location, unless you specifically ask them.

PetrCBR wrote: ↑Sat Jul 04, 2020 7:19 am MM should copy your MM4 database to new MM5.DB name and update ini entry for DBName so it looks like for any reason ini wasn't updated with new DBName and need to figure out why it wasn't get updated.

Look at whether MM5 persists the ini file if the user allows MM5 to autostart from the install proc, and accepts importation|upgrade of the MM4 db, and then closes MM5 as soon as it completes, without interacting with the UI. ... That is what i did. ... I am fairly confident that I closed MM5 normally, because at that stage I thought that I had a good db, and just wanted to backup it up.

btw It did put a MM5.db into my custom location, and that db's contents were as expected. .... The problem is that when MM5 was started again it went back to MM.db, and upgraded it.

Oh, that reminds me. ... maybe I did interact with the UI once. I think that I opened File|ManageDb, and clicked the backup icon, so I could check the db location ... I didn't run the backup. And then I closed Mm5

Thanks for response.

by **PetrCBR** » Sat Jul 04, 2020 7:54 am

I've added code to always use MM5.DB even when different name is defined in INI file to be sure MM4 database isn't used in case INI file is not updated after data import.

by **PetrCBR** » Sat Jul 04, 2020 7:19 am

Even in portable mode you can define custom DB location and when you've choosed to import settings from MM4, custom DB location was imported as well.
MM should copy your MM4 database to new MM5.DB name and update ini entry for DBName so it looks like for any reason ini wasn't updated with new DBName and need to figure out why it wasn't get updated.

by **Barry4679** » Sat Jul 04, 2020 3:24 am

PetrCBR wrote: ↑Tue Jun 16, 2020 2:06 pm It will be fixed in next build.

And what about the build after that one?
I have just installed it (5.0.0.2259), and it has corrupted my MM4 database again.
Petr, this is a really sad thing to witness. I am beyond words.

Observations:
1. I installed MM5 in portable mode. ... What is the definition of "portable mode"? .. I was expecting that MM would be entirely installed in the directory that I supplied, ie. including the database. ... When I started MM5 I it allowed to import data and settings from MM4. ... This seems to have overridden my request for a portable install, because it build the MM5 database outside of the directory that I nominated. ... This is unexpected. ... My MM4 installation has a custom database location. But If I then request a portable install, you shouldn't silently override that request ... agree?

2. After MM5 had started, and before I used it for anything, I closed MM5, and backed up the database that it had built (this was when I noticed it was in unexpected location) ... Then I started MM5 again ... and it flashed up the dbox saying that the db was being upgraded, ... no option to no say No ... Since the MM5 db was already built at version 5, previous experiences have taught me that you had just corrupted my MM4 database for the 4th time, with pretty much the same bug. ... I opened MM4, and this dbox message confirms it ... strange thing to note is that you have taken it just to 5.0.19 this time ... the last time you took it to 5.0.51 .. ?

I restored my MM4 db to a version from 2 days ago, and the problem is repaired.

by **Peke** » Fri Jun 19, 2020 2:47 pm

Hi,
Sorry you can read all at https://www.ventismedia.com/mantis/view.php?id=16718 it was feature that was not ported to MM5 till recently and when we ported it we missed that for custom DBName MM5 should create new file instead of using old MM4 one (eg. upgrade as you noticed the hard way).

It is fixed and now MM5 2257 do not do that but rather create MM5.DB. Further to be improved in 2258. So not trust me, but tested.

If I missed something in past please remind me and I shall try to fix mistakes.

by **Barry4679** » Wed Jun 17, 2020 10:47 pm

krudyp wrote: ↑Wed Jun 17, 2020 9:56 pm It's beta software and comes with a warning to backup your files. The whole point of testing out the software is to find these types of bugs.

Hi,

I don't disagree. I am not complaining about the bug. Just the lack of response to suggestions and criticism. .
eg. I asked multiple times, without answer, asking them to take that version down, once it was clear that it was capable of damaging customer data.

And btw I do backup any tracks that I am about to alter with MM5 tests. But who knew that you had to backup your whole PC to be safe when testing MM5? .. ie. it reached out of its Portable sandbox, and updated a file from another application, in a different disk drive.

by **krudyp** » Wed Jun 17, 2020 9:56 pm

It's beta software and comes with a warning to backup your files. The whole point of testing out the software is to find these types of bugs.

by **Barry4679** » Wed Jun 17, 2020 9:38 pm

Peke wrote: ↑Wed Jun 17, 2020 7:54 pm in 2257 Custom MM4 DB file is not touched at all. MM5 creates new library in it default paths on import. It dosn't matter if MM5 is installed as portable or not.

OK Peke, effectively you say "trust me".

I do, but since you have burnt me three times now, I will backup my MM4 db before touching any MM5 beta again, and would recommend that anyone else do the same.

I have looked further back, and now see that this was a sloppy "accident" just waiting to happen. ... ie from 2017:

In response to:

Barry4679 wrote: ↑Wed Feb 15, 2017 4:22 am The MM4 db and MM4 configuration are now imported into C:\MediaMonkey\Portable\
And updates made with MM5 now update just that MM5 database copy.

But the imported MM ini file (C:\MediaMonkey\Portable\MediaMonkey.ini) retains my MM4 database location override pointing to my MM4 database, ie.
[System]
DBName=D:\xxxxx

I'm not sure why this isn't confusing MM5, but it would be confusing to anyone looking at the ini file wouldn't it?

and the 8 word "trust me" response at that time was:

PetrCBR wrote: ↑Thu Feb 16, 2017 3:30 am Currently database from portable folder is always used.

I think that I am done venting ... this would have been a very much shorter thread if MM Devs:

pulled v2256 when it became clear that was capable of damaging a production database ... ie. any slash and burn testing was updating the MM4 db, and the MM4 database was being screwed up by being updated to MM5 format ... I see that it has been replaced with an out-of-cycle fix today

actually accepted, or responded, to criticism

and when they let their volunteer testers down, an apology would go a long way

My MM4 db has become upgraded to MM5 somehow? [#16718]

Post a reply

Expand view Topic review: My MM4 db has become upgraded to MM5 somehow? [#16718]

Re: My MM4 db has become upgraded to MM5 somehow? [#16718]

Re: My MM4 db has become upgraded to MM5 somehow? [#16718]

Re: My MM4 db has become upgraded to MM5 somehow? [#16718]

Re: My MM4 db has become upgraded to MM5 somehow? [#16718]

Re: My MM4 db has become upgraded to MM5 somehow? [#16718]

Re: My MM4 db has become upgraded to MM5 somehow? [#16718]

Re: My MM4 db has become upgraded to MM5 somehow? [#16718]

Re: My MM4 db has become upgraded to MM5 somehow? [#16718]

Re: My MM4 db has become upgraded to MM5 somehow? [#16718]

Re: My MM4 db has become upgraded to MM5 somehow? [#16718]

Re: My MM4 db has become upgraded to MM5 somehow?

Re: My MM4 db has become upgraded to MM5 somehow?

Re: My MM4 db has become upgraded to MM5 somehow?

Re: My MM4 db has become upgraded to MM5 somehow?

Re: My MM4 db has become upgraded to MM5 somehow?