by drakinite » Sat Oct 30, 2021 12:14 pm
Thanks a ton for the feedback! It especially feels great when we're able to sneak in a big performance boost. (Previously, when customLESS changed, it was recompiled on every sub-window; but now it's only compiled on the main window, and the sub-windows just reload the CSS)
1) I forgot about that! Tracked as #1 in
https://www.ventismedia.com/mantis/view ... 449#c65583
2) That's a good point. However, I couldn't really think of any other way to procedurally create those keys in a way that was reliable. I considered including the option "title" in there, but the title can easily be changed. and that would break it. Do you have any other ideas? Perhaps an optional "id" attribute? Personally, I don't think requiring a user-set "id" is the best option, because the goal of this feature is to help skin developers who don't have much programming knowledge.
3) Picking up default values from a LESS file wouldn't be feasible. I suppose I
could make the "reset changes" button clear the customLESS value for dropdown and color picker controls, because those are hard-associated with only a single variable. But since radiogroup options are significantly more complex, I don't think it would be feasible to force all of their associated variables to be clear. (This is because different radiogroup options can
technically set different variables, even though it's not a good idea to do so.)
Perhaps an alternative could be that skin-specific customLESS attributes be saved with an associated addon version, and they get reset when a new version of the addon is installed? After all, after #1 is implemented, the user will be prompted with the skin options next time they update the addon.
Thanks a ton for the feedback! It especially feels great when we're able to sneak in a big performance boost. (Previously, when customLESS changed, it was recompiled on every sub-window; but now it's only compiled on the main window, and the sub-windows just reload the CSS)
1) I forgot about that! Tracked as #1 in https://www.ventismedia.com/mantis/view.php?id=18449#c65583
2) That's a good point. However, I couldn't really think of any other way to procedurally create those keys in a way that was reliable. I considered including the option "title" in there, but the title can easily be changed. and that would break it. Do you have any other ideas? Perhaps an optional "id" attribute? Personally, I don't think requiring a user-set "id" is the best option, because the goal of this feature is to help skin developers who don't have much programming knowledge.
3) Picking up default values from a LESS file wouldn't be feasible. I suppose I [i]could[/i] make the "reset changes" button clear the customLESS value for dropdown and color picker controls, because those are hard-associated with only a single variable. But since radiogroup options are significantly more complex, I don't think it would be feasible to force all of their associated variables to be clear. (This is because different radiogroup options can [i]technically[/i] set different variables, even though it's not a good idea to do so.)
[i]Perhaps[/i] an alternative could be that skin-specific customLESS attributes be saved with an associated addon version, and they get reset when a new version of the addon is installed? After all, after #1 is implemented, the user will be prompted with the skin options next time they update the addon.